Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos.

ordex has posted comments on this change by mrbff. ( 
http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email )

Change subject: PUSH_UPDATE server: check IV_PROTO before sending the message 
to the client
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

File src/openvpn/push_util.c:

http://gerrit.openvpn.net/c/openvpn/+/1255/comment/9f86880a_824507c6?usp=email :
PS2, Line 294:             msg(M_CLIENT, "ERROR: Peer ID: %u has not been 
updated", curr_mi->context.c2.tls_multi->peer_id);
I thought we wanted to print a message only in the BY_ID command, no? Here it's 
the broadcast branch.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec
Gerrit-Change-Number: 1255
Gerrit-PatchSet: 2
Gerrit-Owner: mrbff <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: cron2 <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: mrbff <[email protected]>
Gerrit-Comment-Date: Thu, 09 Oct 2025 11:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to