Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
mrbff has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email ) Change subject: PUSH_UPDATE server: check IV_PROTO before sending the message to the client ...................................................................... Patch Set 2: (1 comment) File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1255/comment/b02c6dcb_0391bff1?usp=email : PS2, Line 294: msg(M_CLIENT, "ERROR: Peer ID: %u has not been updated", curr_mi->context.c2.tls_multi->peer_id); > I thought we wanted to print a message only in the BY_ID command, no? Here > it's the broadcast branch […] this is unrelated to the new patch, the error message was already, here, but it is not triggered by the presence or not of the IV_PROTO_PUSH_UPDATE. It's just in case there is another generic problem, it should not happen normally. I just removed the inline statement since I assert that tls_multi is not NULL (in support_push_update()). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec Gerrit-Change-Number: 1255 Gerrit-PatchSet: 2 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: cron2 <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 11:45:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
