Attention is currently required from: flichtenheld, mrbff, plaisthos.

cron2 has posted comments on this change by mrbff. ( 
http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email )

Change subject: PUSH_UPDATE server: check IV_PROTO before sending the message 
to the client
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2:
This does not work for me.

I have 3 clients connected, 2 with "master, sends IV" and 1 on 2.6 
(freebsd-14-amd64 is "2.6")

```
CLIENT_LIST     freebsd-14-amd64        udp6:194.97.140.5:64748 10.204.2.46    
fd00:abcd:204:2::100a    6448    5636    2025-10-10 09:57:55     1760083075     
MyTokenUser      57      2       AES-256-GCM
CLIENT_LIST     cron2-freebsd-tc-amd64-25       udp6:194.97.140.21:25690       
10.204.2.38      fd00:abcd:204:2::1008   5383    5284    2025-10-10 09:58:43    
1760083123       MyTokenUser     59      3       AES-256-GCM
CLIENT_LIST     cron2-macos-arm64-m2    udp6:193.149.48.144:51724       
10.204.2.50     fd00:abcd:204:2::100b   8497    7237    2025-10-10 09:52:05     
1760082725      MyTokenUser     55      0       AES-256-GCM
```

Then I do a push-update-broad "-dns" (something harmless).  The log file shows

```
Oct 10 09:59:17 gentoo tun-udp-p2mp[24491]: SENT CONTROL [freebsd-14-amd64]: 
'PUSH_UPDATE,-dns' (status=1)
Oct 10 09:59:17 gentoo tun-udp-p2mp[24491]: SENT CONTROL 
[cron2-macos-arm64-m2]: '' (status=1)
Oct 10 09:59:17 gentoo tun-udp-p2mp[24491]: Failed to process push update 
message sent to client ID: 0
```

why only 2 clients?  why is the message empty on the second one?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec
Gerrit-Change-Number: 1255
Gerrit-PatchSet: 2
Gerrit-Owner: mrbff <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: mrbff <[email protected]>
Gerrit-Comment-Date: Fri, 10 Oct 2025 08:03:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to