Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.

its_Giaan has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/880?usp=email )

Change subject: mroute/management: fix uninitialized variable (UNINIT)
......................................................................


Patch Set 4:

(3 comments)

File src/openvpn/manage.c:

http://gerrit.openvpn.net/c/openvpn/+/880/comment/1917e810_8df15a58 :
PS3, Line 597:             n_killed = 
(*man->persist.callback.kill_by_cn)(man->persist.callback.arg, p2);
> Ah, no, not that one :-) for CN we only have p1
Done


http://gerrit.openvpn.net/c/openvpn/+/880/comment/76fd57cc_1aede7fa :
PS3, Line 600:                 msg(M_CLIENT, "SUCCESS: common name '%s' found, 
%d client(s) killed", p2, n_killed);
> too enthusiastic
Done


http://gerrit.openvpn.net/c/openvpn/+/880/comment/1f0de4eb_2449a9e2 :
PS3, Line 604:                 msg(M_CLIENT, "ERROR: common name '%s' not 
found", p2);
> and here
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 4
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-CC: ordex <a...@unstable.cc>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: ordex <a...@unstable.cc>
Gerrit-Comment-Date: Wed, 29 Jan 2025 10:54:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <g...@greenie.muc.de>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to