Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/880?usp=email ) Change subject: mroute/management: fix uninitialized variable (UNINIT) ...................................................................... Patch Set 2: Code-Review-1 (3 comments) Patchset: PS2: close :-) File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/880/comment/5aaed102_183dab88 : PS2, Line 211: Thanks for this. I overlooked this in v1, though - I think we should have protocol at the start `tcp:1.2.3.4:4000`, as this is really the "most common way", and since we *print* the addresses that way now this would be more logical. Sorry for not spotting this earlier. Also, we might mention "this isn't working for IPv6-connected clients (yet), kill by CN or CID instead". File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/898e15ca_959b2a49 : PS2, Line 564: As discussed in the management-notes.txt comment, I am convinced that it's more logical to do protocol first, so p1 -> protocol, p2 -> IP, p3 -> port then. Sorry again. We do the msg() in that format already ;-) Besides this, the new version & error handling look acceptable (we discussed getting rid of ascii2proto() and just checking for "udp" or "tcp" here, but it does not make much of a difference). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1 Gerrit-Change-Number: 880 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 29 Jan 2025 09:40:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
