Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/880?usp=email ) Change subject: mroute/management: fix uninitialized variable (UNINIT) ...................................................................... Patch Set 3: Code-Review-1 (4 comments) Patchset: PS3: too much enthusiasm File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/a30bd653_c1d4c73d : PS3, Line 597: n_killed = (*man->persist.callback.kill_by_cn)(man->persist.callback.arg, p2); Ah, no, not that one :-) for CN we only have p1 http://gerrit.openvpn.net/c/openvpn/+/880/comment/47dd9eb5_409a4c6d : PS3, Line 600: msg(M_CLIENT, "SUCCESS: common name '%s' found, %d client(s) killed", p2, n_killed); too enthusiastic http://gerrit.openvpn.net/c/openvpn/+/880/comment/986c2548_b64f20f8 : PS3, Line 604: msg(M_CLIENT, "ERROR: common name '%s' not found", p2); and here -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1 Gerrit-Change-Number: 880 Gerrit-PatchSet: 3 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 29 Jan 2025 10:07:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
