Attention is currently required from: MaxF, cron2, flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/796?usp=email )

Change subject: Trigger renegotiation of data key if getting close to the AEAD 
usage limit
......................................................................


Patch Set 7:

(2 comments)

File src/openvpn/crypto.h:

http://gerrit.openvpn.net/c/openvpn/+/796/comment/425b7b90_d202b3d9 :
PS7, Line 169:     /** Counter for the number of plaintext encrypted using this 
cipher
             :      * in number of 128 bit blocks (only used for AEAD ciphers) 
*/
> This looks a bit garbled. […]
Done


File src/openvpn/crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/796/comment/3b5c18b9_d1b170ca :
PS7, Line 347: q <= (p^(1/2) * 2^(129/2) - 1) / (L + 1)
> We're not doing anything with this inequality. […]
Yes, I will remove that one. The earlier version used L but it is easier do the 
block counting that actually figuring out L.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/796?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I057f007577f10c6ac917ee4620ee3d2559187dc7
Gerrit-Change-Number: 796
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: MaxF <m...@max-fillinger.net>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: cron2 <g...@greenie.muc.de>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: MaxF <m...@max-fillinger.net>
Gerrit-Comment-Date: Sat, 30 Nov 2024 12:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: MaxF <m...@max-fillinger.net>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to