Attention is currently required from: cron2, plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/796?usp=email )

Change subject: Trigger renegotiation of data key if getting close to the AEAD 
usage limit
......................................................................


Patch Set 6: Code-Review-2

(6 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/796/comment/6f5c1440_6ba1cc3d :
PS6, Line 17: For a VPN OpenVPN, the same calculation would either require 
using a
"VPN like OpenVPN"? Or just "For OpenVPN"?


http://gerrit.openvpn.net/c/openvpn/+/796/comment/e9855faf_bebc8208 :
PS6, Line 24: To avoid this dynamic calculation and also avoiding needing to 
know the
"avoid"


http://gerrit.openvpn.net/c/openvpn/+/796/comment/56e7feb1_cedb0de9 :
PS6, Line 29: This also has the side effects that connection with a lot of 
small packets
"connections"


http://gerrit.openvpn.net/c/openvpn/+/796/comment/374d394d_c29d4c00 :
PS6, Line 30: (like TCP ACKs) mixed with large packets will be able to keep 
using the same
"same key"?


http://gerrit.openvpn.net/c/openvpn/+/796/comment/4815cde9_b38338fa :
PS6, Line 34: of the
"of the actual limit"?


http://gerrit.openvpn.net/c/openvpn/+/796/comment/efd85c78_167db128 :
PS6, Line 50: Change-Id: I057f007577f10c6ac917ee4620ee3d2559187dc7
Why does this have three Change-Ids?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/796?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I057f007577f10c6ac917ee4620ee3d2559187dc7
Gerrit-Change-Number: 796
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: cron2 <g...@greenie.muc.de>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Comment-Date: Thu, 28 Nov 2024 10:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to