Attention is currently required from: cron2, flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/796?usp=email )

Change subject: Trigger renegotiation of data key if getting close to the AEAD 
usage limit
......................................................................


Patch Set 3:

(2 comments)

File src/openvpn/crypto.h:

http://gerrit.openvpn.net/c/openvpn/+/796/comment/7d70e94e_b31d44b6 :
PS1, Line 615:  * Since cipher_ctx_block_size() is reliable and will return 1 
in many
> "is not reliable"?
Done


File src/openvpn/crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/796/comment/1fd81608_087915dd :
PS1, Line 40: #include <math.h>
> where's that coming from?  I see not math-typical functions being called 
> (round() etc) in the new co […]
Earlier version used math to calculate those limits but then I got into all the 
linking problem with -lm and then decided that I rather use in based math 
instead ....



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/796?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I057f007577f10c6ac917ee4620ee3d2559187dc7
Gerrit-Change-Number: 796
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: cron2 <g...@greenie.muc.de>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Thu, 14 Nov 2024 13:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <g...@greenie.muc.de>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to