Attention is currently required from: flichtenheld, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email )
Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 6: (6 comments) File doc/man-sections/link-options.rst: http://gerrit.openvpn.net/c/openvpn/+/436/comment/e41c0651_4dde7880 : PS5, Line 114: 0.0.0.0 or :: can be used to specifically open a socket. > Sentence does end in the middle? Done http://gerrit.openvpn.net/c/openvpn/+/436/comment/5a0ba867_50a05ad8 : PS5, Line 117: or name > Should probably say "default TCP/UDP port number" or something like that and > mention that this can b […] Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/bea38f19_4d89f447 : PS5, Line 2400: * Sanity check on daemon mode > Not sure what daemon is supposed to mean in this context? Done http://gerrit.openvpn.net/c/openvpn/+/436/comment/a4fc0da7_d28cb303 : PS5, Line 3198: if (ce->proto == PROTO_UDP && ce->socks_proxy_server && !ce->local_list && !ce->local_port_defined && !ce->bind_defined) > Should use need_bind to simplify the condition. Done http://gerrit.openvpn.net/c/openvpn/+/436/comment/08d0b545_36ce02f5 : PS5, Line 3327: options_postprocess_mutate_le(struct options *o, struct local_entry *le) > should maybe take o->ce as input and not o, just to make clear that it > doesn't need the rest? Done File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/f094b608_24a1894e : PS5, Line 358: options > either this should use "l" or the definition of "l" should be removed > completely. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 6 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Thu, 17 Oct 2024 14:50:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
