Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email )
Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 2: Code-Review-1 (4 comments) Patchset: PS2: Need to look into the macOS build failures. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/d52e4152_214d8bc0 : PS2, Line 127: "--local host|* [port] : Local host name or ip address and port. '*' can be used\n" Some of this should move to the documentation instead. http://gerrit.openvpn.net/c/openvpn/+/436/comment/84cfb07a_49de2180 : PS2, Line 997: befor "be for"? File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/cbf102c9_02a57533 : PS2, Line 345: int i, j; For new code please move the declaration to the actual first use. No need to stay in pre-C99 style. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 2 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 25 Sep 2024 14:12:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
