Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email )
Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 5: Code-Review-1 (7 comments) File doc/man-sections/link-options.rst: http://gerrit.openvpn.net/c/openvpn/+/436/comment/82b9206f_257c5965 : PS5, Line 114: 0.0.0.0 or :: can be used to specifically open a socket. Sentence does end in the middle? http://gerrit.openvpn.net/c/openvpn/+/436/comment/729f1acd_879715ca : PS5, Line 117: or name Should probably say "default TCP/UDP port number" or something like that and mention that this can be overridden by individual --local entries. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/e215e510_be593b03 : PS5, Line 2400: * Sanity check on daemon mode Not sure what daemon is supposed to mean in this context? http://gerrit.openvpn.net/c/openvpn/+/436/comment/7f064a0d_b60cd452 : PS5, Line 3198: if (ce->proto == PROTO_UDP && ce->socks_proxy_server && !ce->local_list && !ce->local_port_defined && !ce->bind_defined) Should use need_bind to simplify the condition. http://gerrit.openvpn.net/c/openvpn/+/436/comment/09c9c53d_d50c5988 : PS5, Line 3327: options_postprocess_mutate_le(struct options *o, struct local_entry *le) should maybe take o->ce as input and not o, just to make clear that it doesn't need the rest? http://gerrit.openvpn.net/c/openvpn/+/436/comment/5052e26b_a665c5df : PS5, Line 6247: if (strcmp(p[1], "*") != 0) should we issue a warning if someone specifies "--local *" without port number that this is a NOOP? File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/c0b1d821_0f10076d : PS5, Line 358: options either this should use "l" or the definition of "l" should be removed completely. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 5 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: its_Giaan <gianma...@mandelbit.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 16 Oct 2024 14:06:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
