Attention is currently required from: flichtenheld, plaisthos.

ralf_lici has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/739?usp=email )

Change subject: Support CIDR on options and extend netbits usage
......................................................................


Patch Set 5:

(3 comments)

File doc/man-sections/vpn-network-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/739/comment/e9b1f04d_20390532 :
PS3, Line 220:      ifconfig local rn
> Yes, I think that is a good idea.
Done


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/739/comment/4b0a66fc_21822d3b :
PS3, Line 7071:             add_route_to_option_list(options->routes, p[1], 
NULL, p[2], p[3]);
> yeah, it is fine. More idle wondering. […]
Acknowledged


File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/739/comment/0d09b12f_5f27c1f4 :
PS4, Line 559:             const in_addr_t public_net = public & netmask;
> Turns out, it was formatted wrong because uncrustify thinks "public" is a 
> keyword and not a variable […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/739?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iae04ad8715e40dfc76475c2c5b9a766c9604efc9
Gerrit-Change-Number: 739
Gerrit-PatchSet: 5
Gerrit-Owner: ralf_lici <r...@mandelbit.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Tue, 17 Sep 2024 16:12:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Comment-In-Reply-To: ralf_lici <r...@mandelbit.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to