Attention is currently required from: its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email )
Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 8: Code-Review-1 (3 comments) Patchset: PS8: Minor nitpick: function call and prototype having empty brackets `()` instead of proper `(void)`. This needs to be fixed, and I can't do code changes on merge. File src/openvpn/ssl.h: http://gerrit.openvpn.net/c/openvpn/+/523/comment/5680c4c5_ce81e31d : PS8, Line 402: bool ssl_get_auth_nocache(); this needs to have a `(void)` there. File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/7c301b9f_a12ccb3f : PS8, Line 341: ssl_get_auth_nocache() this needs to have a `(void)` there. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 8 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Wed, 19 Jun 2024 10:17:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
