Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email )
Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 6: Code-Review-2 (2 comments) File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/5c0d5864_4b0d142a : PS6, Line 299: else if (!static_proxy_user_pass.nocache) Do not actually need to check for nocache here. Since it will never be defined when nocache is set. So the check is redundant. You can even remove the else completely then and just always use static_proxy_user_pass at this point in the function. http://gerrit.openvpn.net/c/openvpn/+/523/comment/b8aa24f7_cae22dbf : PS6, Line 304: else if (static_proxy_user_pass.nocache && !force) I think this condition is too complicated. What does this have to do with force? Also why the "else"? Just always delete it when nocache is true... Or am I missing something? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 6 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Tue, 12 Mar 2024 11:04:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
