Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email )
Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 6: (1 comment) File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/a8be4b5f_3cc2fa9a : PS6, Line 304: else if (static_proxy_user_pass.nocache && !force) > I think we need it otherwise in case of nocache true creds would be wiped at > the first call of the g […] You're right about the force. I didn't really think about the fact that when you don't use "auto" get_user_pass_http is going to be always called twice. But that also invalidates my other suggestion about the "else". The test for force is not enough since on restart force will be false for the first call. And it that case we should not clear it. I think we should go back to the previous iteration in this case. Move it out of the function again after the second get_user_pass_http. We really only want to delete it there after all. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 6 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Tue, 12 Mar 2024 12:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: its_Giaan <gianma...@mandelbit.com> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
