Acked-by: Gert Doering <[email protected]>
Thanks for the v4. This enabled me to just push to GH to have
to build and run the tests, without having to bother myself with
copying binaries around :-)
OTOH, there might be a bit of polishing needed - the other tests
print out what they are doing ("Running 7 test(s)"), while the
cryptoapi unit test "just succeeds". Is there something missing
wrt cmocka initalization?
https://github.com/cron2/openvpn/actions/runs/4270790193/jobs/7434873211
I also did do a MinGW "make check" and it built the new test binary
just fine, and succeeded otherwise.
298368 704 -rwxrwxr-x 1 gert gert 718042 Feb 25 16:10
./tests/unit_tests/openvpn/.libs/cryptoapi_testdriver.exe
The unit test itself looks reasonably complete in testing expected
and error-handling behaviour (v3->v4). Not much coverage beyond
"parse_hexstring()", but it's a good start to build upon :-)
Your patch has been applied to the master and release/2.6 branch.
commit 8aff5655a51d9f9f67ca31b363d4ebaf5342d410 (master)
commit 094aea56ce20d0bb6fe79e6e14a3dfe68ea11786 (release/2.6)
Author: Selva Nair
Date: Tue Feb 14 15:08:04 2023 -0500
Add a unit test for functions in cryptoapi.c
Signed-off-by: Selva Nair <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg26268.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
