Hi, On Sat, Feb 04, 2023 at 01:40:10AM -0500, selva.n...@gmail.com wrote: > From: Selva Nair <selva.n...@gmail.com> > > - Though named cryptoapi_testdriver, right now this only tests > parsing of thumbprint specified as a selector for --cryptioapicert > option. More tests coming.. > > v2: a line that belongs here was mistakenly included in the previous > commit. Corrected.
So, unit test are good, especially for the Windows bits that could
really use more testing - so thanks for that.
OTOH, having the test here without adding it to .github/workflows/build.yaml
means "it not run automatically". How do we want to do that, do you want
to send a v3 with build.yaml extended, or shall I merge this as is, and
we do a separate patch "... and now run the unit test"?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
