Hi, On Tue, Feb 7, 2023 at 7:18 PM Arne Schwabe <[email protected]> wrote:
> Am 04.02.23 um 07:40 schrieb [email protected]: > > From: Selva Nair <[email protected]> > > > > - Though named cryptoapi_testdriver, right now this only tests > > parsing of thumbprint specified as a selector for --cryptioapicert > > option. More tests coming.. > > > > v2: a line that belongs here was mistakenly included in the previous > > commit. Corrected. > > > > Signed-off-by: Selva Nair <[email protected]> > > While a good step, this still has problems. With OpenSSL 1.1.1 it still > tries to run the check-engine.sh script and unsurprisingly fails: > > ---- begin log.txt ---- > ./check_engine_keys.sh: 25: ../../../src/openvpn/openvpn: not found > --- end log.txt --- > Key mismatch not detected > FAIL: check_engine_keys.sh > > This can be fixed by: > > --- a/tests/unit_tests/engine-key/Makefile.am > +++ b/tests/unit_tests/engine-key/Makefile.am > @@ -12,7 +12,9 @@ TESTS_ENVIRONMENT = srcdir="$(abs_srcdir)"; \ > top_srcdir="$(top_srcdir)"; \ > export srcdir builddir top_builddir top_srcdir; > > +if !CROSS_COMPILING > TESTS = check_engine_keys.sh > +endif > check_engine_keys.sh: $(conffiles) > > CLEANFILES = \ > Thanks for this. I added this to 2/3 where it belongs and submitted it as v3 2/3. With that, this patch should be okay as is. For those not following closely, this patch should be applied after the cryptoapi patch set where the function being tested here is introduced. Selva
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
