On Wed, 13 Nov 2019 at 17:18, Gert Doering <g...@greenie.muc.de> wrote: > > Hi, > > It might be related to the way the windows tap6 driver always needs a > gateway address even in tun mode (and uses the last address from the > subnet for this). There's very few typos in OpenVPN code regarding > *this* type of math, and way more "just funny platforms and old lore".
The reason I think it is a typo is because the pool start is network address + 2 (i.e. I think it's a copy-and-paste kind of typo). AFAIK, the gateway address issue is addressed in commit 4cc6a25 by using the pool start for that. (The commit message stated that using the address of the server does not work for Windows.) In any case, should I just keep it as-is just to be "conservative"? > Not sure. This code has been rewritten a number of times over the > years, so maybe the assignment slipped outside of an if() block... Again, should I keep it as-is, or "try it and see"? > Things like this can (and should) all be fixed, but please do not lump > them together with a functional change in one big patch. No problem, I can split it and resend. > > gert > -- > "If was one thing all people took for granted, was conviction that if you > feed honest figures into a computer, honest figures come out. Never doubted > it myself till I met a computer with a sense of humor." > Robert A. Heinlein, The Moon is a Harsh Mistress > > Gert Doering - Munich, Germany g...@greenie.muc.de _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
