Hi, On 13/11/2019 10:18, Gert Doering wrote: >> By the way, why does `o->ifconfig_pool_netmask` need to be set even >> when `nopool` is set? > > Not sure. This code has been rewritten a number of times over the > years, so maybe the assignment slipped outside of an if() block... > > Things like this can (and should) all be fixed, but please do not lump > them together with a functional change in one big patch.
I agree with Gert here. If you are finding inconsistencies across the code and want to fix them, please do so in small separate patches (related fixes can and should obviously go together). It'll make them easier to be reviewed and merged ;-) On top of that, a fix might be worth backporting to an older release, while a functional change would normally just go to master. Thanks a lot for your contribution though! Cheers, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
