Hi, On Wed, Nov 13, 2019 at 05:13:09PM +0800, Tom Yan wrote: > For the record, as I don't see why `o->ifconfig_pool_end` was > `(o->server_network | ~o->server_netmask) - 2` for tun + subnet while > it was `(o->server_network | ~o->server_netmask) - 1` for tap, I > assume the former is a typo.
It might be related to the way the windows tap6 driver always needs a
gateway address even in tun mode (and uses the last address from the
subnet for this). There's very few typos in OpenVPN code regarding
*this* type of math, and way more "just funny platforms and old lore".
> By the way, why does `o->ifconfig_pool_netmask` need to be set even
> when `nopool` is set?
Not sure. This code has been rewritten a number of times over the
years, so maybe the assignment slipped outside of an if() block...
Things like this can (and should) all be fixed, but please do not lump
them together with a functional change in one big patch.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
