Acked-by: Gert Doering <g...@greenie.muc.de>

Thanks, Selva, for checking what was missing (nothing but context) :-) - I
wasn't feeling familiar enough with the code to check myself yesterday, 
and the large conflict "git cherrypick" created misled me.

I have verified that the patch itself contains the code same changes, just
line numbers and context are different ("diff -u master.patch 24.patch"),
so I cherrypick Steffan's ACK to the master patch and add my own.

Test built on ubuntu1604 with openssl 1.0.1* (so verifying yesterday's 
openssl 1.1-compat patch in 2.4 as well).

Your patch has been applied to the release/2.4 branch.

commit 163fa9c1e79bddc07c7dd47e8c313016b482314f (release/2.4)
Author: Selva Nair
Date:   Fri Oct 5 20:08:15 2018 -0400

     Pass the hash without the DigestInfo header to NCryptSignHash()

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Steffan Karger <steffan.kar...@fox-it.com>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <1538784495-24988-1-git-send-email-selva.n...@gmail.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17579.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to