Hi,

> As a side note (rambling about comments today), this hunk makes the
> comment above it slightly misleading:
>
>      /* The hash OID is already in 'from'.  So set the hash algorithm
>       * in the padding info struct to NULL.
>       */
> -    BCRYPT_PKCS1_PADDING_INFO padinfo = {NULL};
> +    BCRYPT_PKCS1_PADDING_INFO padinfo = {hash_algo};
>
> .. since we do not set it to NULL anymore...
>

A perfect case of how fast comments and code diverge -- I added that
comment only
the other day.. My bad. Will try to remember to fix next time this is
touched.

Knuth's literate programming never caught on, did it..

Thanks for the ack and merge..

For 2.4, have to look through and figure out --- it has been a while..

Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to