Your patch has been applied to the master branch. Steffan says "it is
a bugfix so it should go to 2.4", but the underlying infrastructure
does not seem to be there yet (git cherry-pick tries to bring in lots
of extra stuff). So we can do that, but I need to be told which master
commits I need to bring to 2.4 first.
I have not even stared-at-code very much here, trusting the testers and
Steffan's code-staring abilities.
As a side note (rambling about comments today), this hunk makes the
comment above it slightly misleading:
/* The hash OID is already in 'from'. So set the hash algorithm
* in the padding info struct to NULL.
*/
- BCRYPT_PKCS1_PADDING_INFO padinfo = {NULL};
+ BCRYPT_PKCS1_PADDING_INFO padinfo = {hash_algo};
.. since we do not set it to NULL anymore...
commit 6b495dc4c5cfc118091ddc9c19330b3c9e3e3dff (master)
Author: Selva Nair
Date: Thu Apr 26 10:24:24 2018 -0400
Pass the hash without the DigestInfo header to NCryptSignHash()
Acked-by: Steffan Karger <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg16840.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
