Hi, On Tue, Aug 7, 2018 at 2:59 PM, Gert Doering <g...@greenie.muc.de> wrote:
...some good comments snipped... > > There's another catch which we might want to at least document: if you > build this plugin and run it from a slightly older openvpn binary which > doesn't export the base64 functions, it will core dump most ungraciously > > Aug 7 20:17:19 openvpn-tcp kernel: pid 49459 (openvpn), uid 0: exited on > signal 11 (core dumped) > > (unsurprisingly, jumping over an uninitialized function pointer) > > > So, shall we bump the plugin API version "with base64" to 5, and change > this plugin to actually check it? > > (Applying it anyway, because this can all be addressed in a subsequent > patch) Oh, the version bump was overlooked... David's export patch was obviously written assuming it will get merged soon after the secure_memzero export patch but we took a year and some to get there :) Let's bump the plugin struct version and add a check for it in this plugin. Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
