Hi, On 30/07/18 04:16, Selva Nair wrote: > Yes that's the base64 patch. What is stopping it is not the > disagreement on that patch but an "error" [*] in the plugin header > that I had discovered. David wants to fix that before this one, but > it seems he is too busy with other things. > > And there is a pending patch to fix that : > https://patchwork.openvpn.net/patch/87/ >
[CUT] > > [*] A function signature uses a pointer to an opaque handle (a void *) > while it should be just the handle. It generates no warning as it is > void * vs void ** and all existing codes out there must be correctly > passing the pointer (handle) ignoring the signature in the header -- > else they wont work. I wanted the header to be fixed and David seems > to agree with that. > I remember discussing this patch with David as well and the general feeling was that the patch was correct. Maybe David wanted to spend some more time on this patch, but it slipped off the plate. As Selva said, if users of that function were following the header they would see a lot of explosions, while this is not the case. Therefore it should be happily applied with no risk. Cheers, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
