Hi, On Thu, Apr 23, 2020 at 10:02:10AM -0400, Selva Nair wrote: > On Tue, Aug 7, 2018 at 3:01 PM Gert Doering <g...@greenie.muc.de> wrote: > > Your patch has been applied to the master branch. > > > > (I'm a bit undecided about release/2.4 - this is in "new feature!" land, > > and all the challenge stuff is "master" territory. OTOH, it's not openvpn > > main code, and the code is sane enough - so if folks think it should be > > in release/2.4, tell me) > > > > commit 7369d01bf360bcfa02f26c05b86dde5496d120f6 (master) > > I failed to respond to this that time. > > Although this is a new feature, I too think its safe and useful to > include this in 2.4. > If we do, we'll need this one (commit > 7369d01bf360bcfa02f26c05b86dde5496d120f6) and the followup one > 7a8109023f4c345fe12f23421c5fa7e88e1ea85b > > Both should cherry-pick without conflicts.
If you tell me we should have it, I'm with you :-)
(Given that this is only affecting the auth-pam plugin, and that this is
a very useful addition, I think it makes sense)
commit cab48ad43eaba51c54fa23e55b0b2eb436dd921f (HEAD -> release/2.4)
Author: Selva Nair <selva.n...@gmail.com>
Date: Tue Aug 7 22:44:31 2018 -0400
Accept empty password and/or response in auth-pam plugin
(cherry picked from commit 7a8109023f4c345fe12f23421c5fa7e88e1ea85b)
commit b89e48b015e581a4a0f5c306e2ab20da34c862ea
Author: Selva Nair <selva.n...@gmail.com>
Date: Tue Jul 24 22:34:53 2018 -0400
Parse static challenge response in auth-pam plugin
(cherry picked from commit 7369d01bf360bcfa02f26c05b86dde5496d120f6)
I've only done very limited testing - quick look at the changes (nothing
conflicting or "funky" here), and a test build.
> See also Trac #1275 https://community.openvpn.net/openvpn/ticket/1275
Noted!
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
