Hi Simon, On Tue, Dec 5, 2017 at 4:44 AM, Simon Rozman <si...@rozman.si> wrote: > Hi, > >> On Wed, Nov 08, 2017 at 06:46:53PM +0000, Simon Rozman wrote: >> > > The best time to re-factor a function would be when a a new use >> > > case needs to change its semantics. Apart from the ill-chosen -err >> > > as a return value, currently it returns 0 if automatic metric is in >> > > use, making it impossible to use it as a generic function to find the >> > > current >> metric of an interface. >> > > >> > > In fact I've a pending patch where such a change would help. >> [..] >> > I shall give it a look after the Hackathon. >> >> "ping"? >> >> This seems to be the only hunk left from the MSVC correction series (as far >> as .c/.h files are concerned, not .proj) >> > > I really appreciate your "ping" Gert. I totally forgot about this one and > have now flagged this thread so I shall finish it in the following weeks. > > The get_interface_metric() function should get a more thorough rewrite than > just a compiler warning shut-up. So the patch will probably get divided in > two - the simple signed/unsigned fixes and get_interface_metric() redesign.
For the latter, I had "re-invented" the get_interface_metric function for the pending "use lowest metric interface when multiple interfaces match a route" patch. Obviously, its better to refactor this one and use it there, so I just copied the implementation and submitted a patch to do so. Unlike I had thought earlier, this has to stay in block_dns.h for ease of sharing with the service. Could you please take a look and see whether it addresses MSVC's concerns among other things? Thanks, Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
