On 05/11/17 20:20, Gert Doering wrote:
>> -modext(LPTSTR dest, int size, LPCTSTR src, LPCTSTR newext)
>> +modext(LPTSTR dest, size_t size, LPCTSTR src, LPCTSTR newext)
>> {
>> int i;
> Not sure why this is needed? The code verifies that size is ">0", so
> a signed variable is ok here.I would label this more as "use size_t for size/length related variables". So I read this more as a coding style change than anything else. From a general point of view, I can agree to such changes. But not convinced that it is strictly needed everywhere. If it silences compiler warnings and don't add "anything else" (behavioural changes or warnings) elsewhere (both code and platform wise), then I'm fairly positive to it. -- kind regards, David Sommerseth OpenVPN, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
