Hi, On Wed, Dec 6, 2017 at 12:10 PM, Simon Rozman <si...@rozman.si> wrote: > Hi, > >> > The get_interface_metric() function should get a more thorough rewrite >> than just a compiler warning shut-up. So the patch will probably get divided >> in two - the simple signed/unsigned fixes and get_interface_metric() >> redesign. >> >> For the latter, I had "re-invented" the get_interface_metric function for the >> pending "use lowest metric interface when multiple interfaces match a >> route" patch. >> >> Obviously, its better to refactor this one and use it there, so I just >> copied the >> implementation and submitted a patch to do so. Unlike I had thought earlier, >> this has to stay in block_dns.h for ease of sharing with the service. >> >> Could you please take a look and see whether it addresses MSVC's concerns >> among other things? > > I have tested and am confirming MSVC is happy with the block_dns.c now. > > Should your patch be merged, I shall rebase the "[PATCH 09/13] > Signed/unsigned warnings of MSVC resolved" to the new master and deliver the > next version.
Yes, if you can review and ack/nak it :) Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
