On Thu, Dec 10, 2015 at 11:49 AM, ValdikSS <i...@valdikss.org.ru> wrote:
> It's a very minor actually, FwpmSubLayerDeleteByKey0 is indeed fails every > time but it doesn't break anything since we close the engine right after. > Lev suggested to use a correct way with making a filter GUID and deleting > it before deleting sublayer, but I'd better go with just closing the engine > without deleting everything. I don't see any drawbacks, that should be > perfectly OK for a dynamic session. Provided it doesn't leak memory. As the current implementation of wfp_add_filter does return the id of the added filter (in &filterid) , its easy to save them into some globals and delete all the filters in wfp_uninit. However, If you are sure there is no leak, just closing the engine is fine. Other than this v8 is good to go. Selva
