It's a very minor actually, FwpmSubLayerDeleteByKey0 is indeed fails every time but it doesn't break anything since we close the engine right after. Lev suggested to use a correct way with making a filter GUID and deleting it before deleting sublayer, but I'd better go with just closing the engine without deleting everything. I don't see any drawbacks, that should be perfectly OK for a dynamic session.
Is this correct, Lev? If yes, I'll push v9 today or tomorrow morning. On 12/10/2015 07:26 PM, Gert Doering wrote: > Hi, > > On Thu, Dec 10, 2015 at 11:55:16AM +0200, Lev Stipakov wrote: > [..] > So, is this something that needs to be fixed before we release 2.3.9, or > can it wait for improvement later on? > > I just agreed with Samuli that we are going to release 2.3.9 on Monday, > and this should go in - so either I get a v9 "with nice and shiny" until > Sunday, or someone tells me "v8 is good enough, go for it"... > > Thanks :-) > > gert > > > ------------------------------------------------------------------------------ > > > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel
signature.asc
Description: OpenPGP digital signature
