Hi, On Tue, Nov 24, 2015 at 07:13:17PM -0500, Selva Nair wrote: > Not sure I understand this. The patch I had tested all along had ifdef > _WINNT_WIN32 >= 0x0600 around everything. So the code nicely silences > itself when built for XP (I did not try this though). I built only 64 bit > version for vista+.
That was the v3 patch, and we decided that we always build master with
VISTA+, and do not want extra #ifdef's if we can avoid them.
> And this was against the master. Now the new sets of patches have different
> ifdefs: _WINNT_WIN32 >= 0x600 for 2.3, and if defined(WIN32) for master.
> This appears unnecessary. Two patches are still needed as some context
> lines have changed between 2.3 and master, but the code could be the same,
> and, in particular, the ifdefs could be just _WINNT_WIN32 >= 0x600.
No #ifdef if they are not needed.
In 2.3 they are needed, because we need to build for XP and Vista+ - in
master, XP support has been dropped and we always build Vista+, so we do
not need the #ifdef bits for _WINNT_WIN32
I'm not sure why we grew #if defined(WIN32) though... that might be due
to "other platforms do not have the functionality at all, so we should
not pretend to understand the option" (comment from Arne). But maybe
these should be #ifdef HAVE_BLOCK_EXTERNAL_DNS which itself is
conditionalized on WIN32 today - it might appear for other platforms,
who knows. No really strong opinion there yet.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
