Hi, On Tue, Nov 24, 2015 at 3:11 PM, Gert Doering <g...@greenie.muc.de> wrote:
> > I still need help with 2.3 build system. If somebody willing to help me, > please use the attached version. > > Well, the 2.3 version would need all the #ifdefs around the code if not > running at VISTA level, and *no* changes to the build system part (so, > 2.3 out of the box would simply not "see" this code at all). > > Samuli would then have to change part of his build system to enable VISTA > API level and add these extra libraries - but that would have to be an > out-of-tree patch applied only to the Vista-and-up installers. Not sure I understand this. The patch I had tested all along had ifdef _WINNT_WIN32 >= 0x0600 around everything. So the code nicely silences itself when built for XP (I did not try this though). I built only 64 bit version for vista+. And this was against the master. Now the new sets of patches have different ifdefs: _WINNT_WIN32 >= 0x600 for 2.3, and if defined(WIN32) for master. This appears unnecessary. Two patches are still needed as some context lines have changed between 2.3 and master, but the code could be the same, and, in particular, the ifdefs could be just _WINNT_WIN32 >= 0x600. May be you mean the same? Selva
