> This was originally supposed to be just a code review
> for porting dmfe 
> to x86, but there were some other outstanding dmfe
> bugs.  Then when I 
> got into packaging, it got ugly, and I discovered
> some other problems... 
> particularly related to the use of a few /etc/ files
> in the packaging 
> system.
> 
> I'd really, really like to have to have an expert in
> the packaging 
> system (especially for kernel-related /etc/ files and
> least-privilege) 
> review the following changes.  I also need someone to
> review the dmfe 
> changes.
> 
> The code review is at
> http://cr.opensolaris.org/~gdamore/dmfe-x86/
> 
> Btw, I'm running these changes (at least the dmfe
> driver portion) with 
> NICDRV on x86 now.  Its been pretty reliable so far.

In "new/usr/src/pkgdefs/SUNWdmfe/prototype_com", I'd set:

d none kernel/drv/amd64 ? ? ?
...
d none kernel/drv/sparcv9 ? ? ?

Instead of specifying the permissions explicitly, then depend on SUNWckr, which 
is the package that owns those dirs.

Also, I'd set

f none kernel/drv/dmfe.conf 0644 root sys

to

e none kernel/drv/dmfe.conf 0644 root sys

Third thing to consider is parametrizing. Instead of setting "root sys" 
explicitly in the prototype file, consider defining something like

SUNW_OWNER=root
SUNW_GROUP=sys

in the pkginfo file, then referencing it the prototype:

e none kernel/drv/dmfe.conf 0644 $SUNW_OWNER $SUNW_GROUP.
 
 
This message posted from opensolaris.org
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code

Reply via email to