FYI, I've committed some patches removing needless - function exports, when nothing outside the file uses those functions; and
- forward declarations, sometimes reordering code The affected files were Cortex-M3 and ARM926. Not marking code (or data) static is sloppy, and hides true interface boundaries. Plus, it prevents compilers from optimizing some things, hides stuff that's really, and makes code needlessly hard to understand (because of that interface boundary issue). Heck, it even makes linking be more expensive (more symbols to crunch). And forward declarations should only really be used when they're unavoidable ... they clutter the code. Let me know if you really want to see such patches come by on the mailing list, and I'll do that too; but my preference is to reduce the noise involved with such *pure cleanup* patches. Changes affecting code flow are what deserve the more-eyes benefits. - Dave _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
