On Sunday 31 May 2009, Zach Welch wrote: > > 1) Remove redundant structure typedefs: > a) Entails the following steps (for each named struct "type"): > i) s/^typedef struct type_s/struct type_s/ > ii) s/^} type_t;/};/ > iii) s/type_t/struct type_s/ > iv) Fix any messes that these commands miss or make. ;) > b) Eliminates what are essentially duplicated symbols: > - simplifies the Doxygen documentation tremendously. > - eliminates style ambiguity and forward referencing.
And makes the code *much* more approachable to anyone who's starting to pick it up ... for example, to help find/fix bugs. > ... > > How do these changes look in the community's eyes? These were on the > list of things to be considered for 0.2.0, but no one addressed them. They look good to me. This is a "friendly" time for such cleanup patches; they will make patches against the 0.2.0+ codebase cleaner. > While I think this would help the code and documentation a > lot, I would even go further to suggest "s/_s//" from all struct names. Most certainly. I realize there are coding conventions that promote such obfuscation, but given the least opportunity I will support non-obfuscated approaches instead. - Dave _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
