Alexei, I believe I have ?
I have submitted the request via "OPENMEETINGS-247 Make document conversion quality an administrator changeable option", but it remains "unassigned" ? While my code works for me in test, I would request that the developers review and convert to the standard that they use, and also add value bounds checking (which I do not know how to implement). If I need to help in other ways by submitting the code in another way, please let me know how. But again I would state again, the code is only to demonstrate what I could to see the requested change to be implemented, not necessarily the final solution. Thanks, George Kirkham IT Manager Cooperative Research Centre For Greenhouse Gas Technologies (CO2CRC) NFF House, 14 - 16 Brisbane Avenue, Barton, ACT, 2600, Australia T: (02) 6120 1600 F: (02) 6273 7181 E: gkirk...@co2crc.com.au, W: www.co2crc.com.au -----Original Message----- From: Alexei Fedotov [mailto:alexei.fedo...@gmail.com] Sent: Saturday, 5 May 2012 8:48 PM To: openmeetings-user@incubator.apache.org; openmeetings-...@incubator.apache.org Subject: Re: Code to increase the quality or resolution of converted PDF or PowerPoint files Hello George, thank you for your contribution. Please could you use JIRA for Apache code contributions? We only can accept contributions under Apache public license, and there is a corresponding flag in JIRA. -- With best regards / с наилучшими пожеланиями, Alexei Fedotov / Алексей Федотов, http://dataved.ru/ +7 916 562 8095 On Fri, May 4, 2012 at 8:36 AM, George Kirkham <gkirk...@co2crc.com.au> wrote: > Hi, > > > > I have that the SWFTools -j (JPEG Quality) and zoom (dpi) options do > a great job in converting text. Currently I have the zoom set to 300 > but have not tested greatly to see if there are any issues like very > large files or very slow connections caused by this. > > > > To allow these two settings to be user adjustable by the OpenMeetings > administrator, I used the below code. > > > > Two Questions: > > 1) I would appreciate it if this change could be added to the > OpenMeetings source. > > 2) Could someone add code to validate that the values when > changed by the administrator, are integers between the acceptable > ranges, e.g. for zoom, between 50 and 600. > > > > /singlewebapp/src/install_step1_EN.vm > > ./src/.svn/text-base/install_step1_EN.vm.svn-base > > > > <fieldset id="userConf1"> > > <legend>Converters</legend> > > <li> > > <label for="swftools_path">SWFTools > Path</label> > > <input name="swftools_path" > id="swftools_path" size="27" > > title="Enter the path to swftools for > example C:/swftools (Windows) or leave blank if swftools is a known to > your system path" type="text" /> > > <p><i>You can test if swftools is > installed into system path by opening a shell or cmd-prompt and type > pdf2swf<br/> > > If this shows a list > of options leave this field blank otherwise you have to specify the > path to pdf2swf on your system<br/> > > see also <a > href="http://incubator.apache.org/openmeetings/installation.html" > target="_blank">Installation</a></i></p> > > </li> > > <li> > > <label for="swftools_zoom">SWFTools > Zoom</label> > > <input name="swftools_zoom" > id="swftools_zoom" size="4" value="100" > > title="Enter the dpi that swftools > will use for PDF to SWF conversion" type="text" /> > > <p><i>You can test if swftools is > installed into system path by opening a shell or cmd-prompt and type > pdf2swf<br/> > > Enter the dpi that > swftools will use for PDF to SWF conversion. Default is 100 dpi.<br/> > > see also <a > href="http://incubator.apache.org/openmeetings/installation.html" > target="_blank">Installation</a></i></p> > > > > </li> > > <li> > > <label for="swftools_jpegquality">SWFTools > JPEG Quality</label> > > <input name="swftools_jpegquality" > id="swftools_jpegquality" size="3" value="85" > > title="Enter the quality of embedded > jpeg pictures to quality. 0 is worst (small), 100 is best (big). (default:85)" > type="text" /> > > <p> > > <i>You can test if swftools is > installed into system path by opening a shell or cmd-prompt and type > pdf2swf<br/> > > Enter the quality of > embedded jpeg pictures to quality. 0 is worst (small), 100 is best (big). > (default:85)<br/> > > see also <a > href="http://incubator.apache.org/openmeetings/installation.html" > target="_blank">Installation</a></i> > > </p> > > </li> > > > > ====================================================================== > =============================== > > > > ./src/org/openmeetings/app/installation/ImportInitvalues.java:298: > > ./src/org/openmeetings/app/installation/.svn/text-base/ImportInitvalue > s.java.svn-base:298 > > > > cfgManagement.addConfByKey(3, > "swftools_zoom", cfg.swfZoom, null, > > "dpi > for conversion of PDF to SWF"); > > > > cfgManagement.addConfByKey(3, > "swftools_jpegquality", cfg.swfJpegQuality, null, > > > "compression quality for conversion of PDF to SWF"); > > > > ---------------------------------------------------------------------- > ------------ > > > > ./src/org/openmeetings/app/installation/InstallationConfig.java:20: > > ./src/org/openmeetings/app/installation/.svn/text-base/InstallationConfig.java.svn-base:20: > > //SWFTools PDF to SWF conversion settings > > public String swfZoom = ""; > > public String swfJpegQuality = ""; > > > > + ", > mailUseTls=" + mailUseTls + ", swfZoom=" + swfZoom > > + ", > swfJpegQuality=" + swfJpegQuality + ", swfPath=" + swfPath > > > > > > > > ---------------------------------------------------------------------- > ------------ > > ./src/org/openmeetings/servlet/outputhandler/Install.java > > ./src/org/openmeetings/servlet/outputhandler/.svn/text-base/Install.ja > va.svn-base:245 > > > > > cfg.swfZoom = httpServletRequest.getParameter("swftools_zoom"); > > > cfg.swfJpegQuality = > httpServletRequest.getParameter("swftools_jpegquality"); > > > > ---------------------------------------------------------------------- > ------------ > > ====================================================================== > =============================== > > ./src/org/openmeetings/app/documents/GenerateSWF.java: > > ./src/org/openmeetings/app/documents/.svn/text-base/GenerateSWF.java.svn-base: > > > > > > private String getSwfZoom() { > > String valueForSwfZoom = > cfgManagement.getConfValue("swftools_zoom", String.class, ""); > > // WARNING CODE NOT COMPLETE: If > SWFTools zoom (dpi) should be an integer between 50 and 600 with a > default value of > 100 dpi > > if (valueForSwfZoom.equals("")) { > > valueForSwfZoom = > "100"; > > } > > return valueForSwfZoom; > > } > > > > private String getSwfJpegQuality() { > > String valueForSwfJpegQuality = > cfgManagement.getConfValue("swftools_jpegquality", String.class, ""); > > // WARNING CODE NOT COMPLETE: If > SWFTools JPEG Quality should be an integer between 1 and 100, with a > default value of > 85 > > if (valueForSwfJpegQuality.equals("")) > { > > valueForSwfJpegQuality > = "85"; > > } > > return valueForSwfJpegQuality; > > } > > > > public HashMap<String, String> generateSwf(String > current_dir, > > String originalFolder, > String destinationFolder, String fileNamePure) { > > > > // Create the Content of the Converter > Script (.bat or .sh File) > > String[] argv = new String[] { > > > getPathToSwfTools() + "pdf2swf" + execExt, "-s", > > > "insertstop", // insert Stop command into every frame > > > "-s","poly2bitmap", > //http://www.swftools.org/gfx_tutorial.html#Rendering_pages_to_SWF_fil > es > > "-i", > // change draw order to reduce pdf complexity > > "-j", > " " + getSwfJpegQuality(), // JPEG Quality to 100 > > "-s", " > zoom=" + getSwfZoom(), // set zoom dpi to 200 > > > originalFolder + fileNamePure + ".pdf", > > > destinationFolder + fileNamePure + ".swf" }; > > > > return > ProcessHelper.executeScript("generateSwf", argv); > > } > > > > ====================================================================== > =============================== > > > > > > Thanks, > > > > George Kirkham > > > > IT Manager > > Cooperative Research Centre For Greenhouse Gas Technologies (CO2CRC) > > NFF House, 14 - 16 Brisbane Avenue, Barton, ACT, 2600, Australia > > T: (02) 6120 1600 > > F: (02) 6273 7181 > > E: gkirk...@co2crc.com.au, > > W: www.co2crc.com.au > > > > > > From: George Kirkham [mailto:gkirk...@co2crc.com.au] > Sent: Wednesday, 2 May 2012 4:58 PM > To: openmeetings-user@incubator.apache.org > Subject: RE: How to increase the quality or resolution of converted > PDF or PowerPoint files > > > > Maxim, > > > > You said “Sebastian already add converter parameter”. > > > > Can you tell me where to set the parameter, what it is called, and in > which version it was introduced? - that would be very helpful. > > > > Thanks, > > > > George Kirkham > > > > IT Manager > > Cooperative Research Centre For Greenhouse Gas Technologies (CO2CRC) > > NFF House, 14 - 16 Brisbane Avenue, Barton, ACT, 2600, Australia > > T: (02) 6120 1600 > > F: (02) 6273 7181 > > E: gkirk...@co2crc.com.au, > > W: www.co2crc.com.au > > > > > > From: Maxim Solodovnik [mailto:solomax...@gmail.com] > Sent: Wednesday, 2 May 2012 3:42 PM > To: openmeetings-user@incubator.apache.org > Subject: Re: How to increase the quality or resolution of converted > PDF or PowerPoint files > > > > Sebastian already add converter parameter > > please check the latest build > > On Wed, May 2, 2012 at 12:37 PM, George Kirkham > <gkirk...@co2crc.com.au> > wrote: > > Hi, > > > > To explain why I would like to increase the PowerPoint slide > conversion process, please review the following clips from screen > shots of an actual PowerPoint presentation slide and that of the slide > as it is in OpenMeetings. > >