On Wed, 20 Aug 2025 23:33:16 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Support background loading of raw input streams
>>
>> - Fixed generics (mix up of two ImageLoader types)
>> - Removed unused code for handling headers, methods, request parameters
>> - Use `long` for progress as streams may exceed 2 GB
>> - Improved documentation of Image regarding background loading
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
Change looks to me apart from some questions.
Will also run tests on our CI system and check.
modules/javafx.graphics/src/main/java/com/sun/javafx/runtime/async/AbstractRemoteResource.java
line 64:
> 62: }
> 63:
> 64: protected AbstractRemoteResource(String url, String method, String
> outboundContent, AsyncOperationListener<T> listener) {
I see that outboundContent calls are no where used. Is this the reason we are
cleaning up this code?
modules/javafx.graphics/src/main/java/com/sun/javafx/runtime/async/AbstractRemoteResource.java
line 113:
> 111: }
> 112: finally {
> 113: stream.close();
Do we have to continue closing the stream when background loading is happening
with URL?
-------------
PR Review: https://git.openjdk.org/jfx/pull/1875#pullrequestreview-3139250464
PR Review Comment: https://git.openjdk.org/jfx/pull/1875#discussion_r2290035538
PR Review Comment: https://git.openjdk.org/jfx/pull/1875#discussion_r2290025539
