On Tue, 19 Aug 2025 20:49:58 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add since tags
>
> modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java line 685:
>
>> 683: * using the specified parameters.
>> 684: * <p>
>> 685: * If loading in the background is requested, then the progress
>> property can
>
> suggestion (also in L734, L776):
>
>
> * If loading in the background is requested, then the {@link
> #progressProperty() progress} property can
Added this for the 4 constructors that have the `backgroundLoading` parameter.
Thanks :)
> modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java line 1136:
>
>> 1134: private AsyncOperation constructPeer() {
>> 1135: if(inputSource == null) {
>> 1136: return loadImageAsync(
>
> minor: wrapping is not necessary in this method
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1875#discussion_r2288227454
PR Review Comment: https://git.openjdk.org/jfx/pull/1875#discussion_r2288225837
