On Tue, 19 Aug 2025 20:46:27 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add since tags
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java
> line 830:
>
>> 828:
>> 829: if(protocol.equals("http") || protocol.equals("https")) {
>> 830: HttpURLConnection conn = (HttpURLConnection)
>> u.openConnection();
>
> I know this code has been copied from `AbstractAsyncOperation`, but would it
> make more sense (anticipating HTTP/3 https://openjdk.org/jeps/517) to open a
> connection and then check if it is `instanceof HttpURLConnection` ?
If you want to pull that into the scope of this feature. I would think doing
this with a dedicated ticket (and then fixing it in all places, not just here)
would be more aligned with trying to keep changes small and focused.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1875#discussion_r2288183035
