On Wed, 18 Jun 2025 17:22:07 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/javafx.graphics/src/main/java/javafx/scene/text/TabStop.java line 33: > >> 31: * left margin, aligns text in a specified way, and has a specified >> leader. >> 32: * >> 33: * @since 999 TODO > > Change this to either 25 (if you'd like to shoot for getting it into 25) or > 26. I hope to get it to 25, but we'll see. Will change once we know more. > modules/javafx.graphics/src/main/java/javafx/scene/text/TabStopPolicy.java > line 67: > >> 65: * >> 66: * @return the default tab stops property >> 67: * @defaultValue 0 > > Would "8" be a better default value? I think having tabs do something > (instead of effectively being ignored) by default when you create a > TabStopPolicy would be less surprising to app developers. No, this value is in pixels (unlike the `tabSize` property). I think it's better to let the application specify it explicitly. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1744#discussion_r2155263491 PR Review Comment: https://git.openjdk.org/jfx/pull/1744#discussion_r2155260675
