On Wed, 9 Jul 2025 20:34:39 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 62 commits: >> >> - since 25 >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8314482.tab.stops >> - Merge remote-tracking branch 'origin/master' into 8314482.tab.stops >> - final tab stop >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8314482.tab.stops >> - cleanup >> - api >> - Merge remote-tracking branch 'origin/master' into 8314482.tab.stops >> - ... and 52 more: https://git.openjdk.org/jfx/compare/639a5950...00bcf4b0 > > modules/javafx.graphics/src/main/java/javafx/scene/text/TabStopPolicy.java > line 54: > >> 52: * @return the non-null list of tab stops >> 53: */ >> 54: public final ObservableList<TabStop> tabStops() { > > Did you consider also dropping "tab" from the name here? Either is fine with > me, so I'll leave it up to you. I prefer `tabStops`. > modules/javafx.graphics/src/main/java/javafx/scene/text/TabStopPolicy.java > line 61: > >> 59: * Specifies the default tab stop interval (beyond the last tab stop >> provided by {@code #tabStops()}), >> 60: * as a fixed repeating distance (in pixels) to the next tab stop >> computed at regular intervals >> 61: * relative to the leading edge of the {@code TextFlow} node. > > This is a bit of a run-on sentence. Maybe consider breaking it up into two > sentences, with the detail about "a fixed, repeating distance..." in the > second sentence? Something like: > > > * Specifies the default tab stop interval for tabs beyond the last stop > provided > * by {@code #tabStops()}. This is a fixed repeating distance (in pixels) > to the > * next tab stop computed at regular intervals relative to the leading edge > * of the {@code TextFlow} node. much better, thank you! ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1744#discussion_r2195966406 PR Review Comment: https://git.openjdk.org/jfx/pull/1744#discussion_r2195968373
