On Tue, 17 Jun 2025 23:00:21 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 56 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8314482.tab.stops >> - cleanup >> - api >> - Merge remote-tracking branch 'origin/master' into 8314482.tab.stops >> - cleanup >> - Merge remote-tracking branch 'origin/master' into 8314482.tab.stops >> - seems to work >> - wired >> - moved >> - Merge remote-tracking branch 'origin/master' into 8314482.tab.stops >> - ... and 46 more: https://git.openjdk.org/jfx/compare/1ea980ea...7acc55db > > modules/javafx.graphics/src/main/java/javafx/scene/text/TabStopPolicy.java > line 60: > >> 58: >> 59: /** >> 60: * Provides default tab stops (beyond the last tab stop specified by >> {@code #tabStops()}, > > Having this be a plural when it is a single value (a double) is awkward. I > would name the property `defaultStop` and document that the default is used > for all stops beyond the last stop. This terminology is borrowed from a well known software product. I think it is apt as it describes the spacing (and the positions) of multiple tab stops, and also the users might be familiar with the term. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1744#discussion_r2154903798
