On Tue, 6 May 2025 07:07:20 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html 
>> line 871:
>> 
>>> 869:             <code>(prefers-color-scheme: dark) and 
>>> (prefers-reduced-motion) or (prefers-reduced-transparency)</code>
>>> 870:             is illegal, as it is unclear what was meant. In this case, 
>>> parentheses must be used to group expressions.
>>> 871:     </ul>
>> 
>> maybe one or two examples would be helpful here.
>
> I don't want to overload cssref with too many examples, as this is not 
> supposed to be a general-purpose CSS documentation. The media query doc is 
> already quite comprehensive as it is. For detailed information, there's 
> always the W3C specification, and hundreds of third-party sources.

I insist: the doc should include an example with an operator, and possibly how 
to achieve A and not B case mentioned earlier.

Assume the reader has no clue how media queries work and does not want to wade 
through the massive and unrelated w3.org spec.  The `cssref.html` should be 
self-sufficient in that sense, in my opinion.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2075729576

Reply via email to