On Fri, 2 May 2025 23:06:55 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 28 commits:
>> 
>>  - Merge branch 'master' into feature/media-queries
>>  - reorder fields
>>  - remove ReadOnlyBooleanWrapper
>>  - Scene preferences only actively observe platform preferences when the 
>> scene is showing
>>  - formatting
>>  - typo
>>  - use equality instead of identity
>>  - rename TokenStream methods
>>  - improved implementation of NullCoalescingPropertyBase
>>  - small refactor
>>  - ... and 18 more: https://git.openjdk.org/jfx/compare/3fdd2138...32abb8a3
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 
> 871:
> 
>> 869:             <code>(prefers-color-scheme: dark) and 
>> (prefers-reduced-motion) or (prefers-reduced-transparency)</code>
>> 870:             is illegal, as it is unclear what was meant. In this case, 
>> parentheses must be used to group expressions.
>> 871:     </ul>
> 
> maybe one or two examples would be helpful here.

I don't want to overload cssref with too many examples, as this is not supposed 
to be a general-purpose CSS documentation. The media query doc is already quite 
comprehensive as it is. For detailed information, there's always the W3C 
specification, and hundreds of third-party sources.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2074850421

Reply via email to