On Mon, 5 May 2025 18:08:57 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 30 commits: >> >> - Merge branch 'master' into feature/media-queries >> - cssref doc >> - Merge branch 'master' into feature/media-queries >> - reorder fields >> - remove ReadOnlyBooleanWrapper >> - Scene preferences only actively observe platform preferences when the >> scene is showing >> - formatting >> - typo >> - use equality instead of identity >> - rename TokenStream methods >> - ... and 20 more: https://git.openjdk.org/jfx/compare/498b7e4c...626a904d > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaQuerySerializer.java > line 72: > >> 70: DataOutputStream os, >> 71: StyleConverter.StringStore >> stringStore) throws IOException { >> 72: os.writeByte(QueryType.of(mediaQuery).ordinal()); > > potential problem: > someone may insert/reorder QueryType enums and break backward compatibility. > at a minimum, a warning comment should be added to QueryType, or perhaps some > more reliable code in read/writeBinary? or perhaps use hard-coded values instead 'c', 'f', 'C', 'd', 'n' ? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2073935721
