On Fri, 11 Apr 2025 22:57:51 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> > You seem to be arguing against media queries themselves
> 
> Probably. I am afraid the CSS subsystem will grow into a monster (I mean, it 
> already is).

It is, and it’s held together by duct tape in many places. That’s why I think 
we should consider the rewrite at some point in the future to put it on solid 
footing (and it’s the only way to get really useful things like variables).

Media queries are pretty orthogonal to that, as most of the implementation will 
be the same with a potential rewrite.

> The follow up question is what you guys think about updating `modena.css` to 
> support the dark mode? I understand the platform preferences and these media 
> queries are prerequisites, what are other things that we'll need?

What’s missing to properly support dark mode is really only the external 
configuration of stylesheets, so I think with media queries in place we have 
everything we need for a dark version of Modena.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1655#issuecomment-2798777347

Reply via email to