On Fri, 28 Feb 2025 15:26:33 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> doc-files/release-notes-24.md line 78: >> >>> 76: `ScrollPane` now only responds to key events when it is the active >>> focus owner. This ensures that custom controls and other UI elements work >>> correctly inside a `ScrollPane`, providing a more consistent and intuitive >>> navigation experience. >>> 77: >>> 78: Applications that prefer the previous behavior, where `ScrollPane` >>> always reacts to arrow keys and other navigational inputs, can manually >>> restore it by adding an event handler. See [this >>> note](notes/24/JDK-8340852-info.md) for an example of how to do this. >> >> Note to reviewers: If you are viewing the rich diffs and try to click on the >> "this note" link, it won't work. If you "View file" then you can test the >> link, which works for me. > >> [this note](notes/24/JDK-8340852-info.md) > > very very minor: > do you think it should spell the name of the file instead of "this note"? > i.e. `[JDK-8340852-ScrollPane.md](notes/24/JDK-8340852-ScrollPane.md)` > [JDK-8340852-ScrollPane.md](notes/24/JDK-8340852-ScrollPane.md) ? In this case, the name of the file is irrelevant to readers of the doc, so I prefer not to. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1712#discussion_r1975640926
